#16585: improved PolynomialSequence
-------------------------------------+-------------------------------------
       Reporter:  malb               |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  commutative        |   Resolution:
  algebra                            |    Merged in:
       Keywords:  sd59               |    Reviewers:  Jakob Kroeker
        Authors:  Martin Albrecht    |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  c0241972230aec8d6ca71dffeca933df5ef9b963
  u/malb/t16585_mpolynomial_sequence |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by malb):

 Hi Jakob, thanks for your review. I started addressing the issues you
 identified.

 > in file src/sage/rings/polynomial/multi_polynomial_ideal.py at line 4139
 I
 > think it should be if d >= 0 instead of if d > 0

 Fixed: `0fa7a24`

 > you introduce option terms=True to choose maximum number of terms.  I
 don't
 > like it, because the option is not self-descriptive, but try to convince
 me.

 I agree, so I changed it. I changed the `True` to `Infinity` and changed
 the behaviour such that when requesting more terms than exist the number
 is silently reduced to the maximum number of available terms: `563baf0`

 PS: Because I am stupid, though, I rebased instead of merged. Hence, I
 believe you'll have to check out the code again, i.e. you can't just git
 pull again in your current branch. Sorry for that!

--
Ticket URL: <http://trac.sagemath.org/ticket/16585#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to