#16508: Add Commutative graded differential algebras.
-------------------------------------+-------------------------------------
       Reporter:  mmarco             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  sd58, sd59,        |    Merged in:
  algebras, nonconmutative, graded   |    Reviewers:  Travis Scrimshaw
        Authors:  Miguel Marco,      |  Work issues:
  John Palmieri                      |       Commit:
Report Upstream:  N/A                |  3900c66255738ade64524eb67878dc67f8fa5c22
         Branch:                     |     Stopgaps:
  public/algebras/cdga-16508         |
   Dependencies:  #17224             |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:49 jhpalmieri]:
 > I've made a few changes: maybe most crucially but also most trivially,
 there was a missing `EXAMPLES::` that was causing docbuilding to fail.

 Whoops.

 > Then I renamed some classes. The one I feel most strongly about is
 `DifferentialCGA`: to me, this sounds like a "differential commutative
 graded algebra", not a "differential defined on a commutative graded
 algebra". So I just renamed it to `Differential`. I changed `CDGAlgebra`
 to `DifferentialGCAlgebra`. (I toyed with `GCAlgebraWithDifferential`, but
 didn't like it as much. I don't care that much, since these class names
 won't be that visible to most users.)

 I'm happy with this name change (it gets the association from the module
 name). However I've rename the method `CDGAlgebra` to `cdg_algbra` match
 conventions.

 > I also added a bit to the docstrings for the two `CDGAlgebra` methods.

 Looks good. So if you're happy with my changes, then I think we can set a
 positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/16508#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to