#17129: Posets constructor does not check argument
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/posets_constructor_does_not_check_argument|  
ef5cc86cce07b935b78d68e59b50c2fa78069381
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vbraun):

 * status:  positive_review => needs_work


Comment:

 Python style for exeption messages is incomplete sentences. In particular,
 no capitalization of the first word and no period at the end. E.g.
 {{{
 $ python
 Python 2.7.8 (default, Oct 27 2014, 15:54:28)
 [GCC 4.9.1 20140930 (Red Hat 4.9.1-11)] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 >>> 1 + '2'
 Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
 TypeError: unsupported operand type(s) for +: 'int' and 'str'
 }}}
 This ticket makes it worse in many places.

--
Ticket URL: <http://trac.sagemath.org/ticket/17129#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to