#16640: Graphics3d.show abuses graphics_filename
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von | Reviewers: Jeroen Demeyer, Karl-
Gagern, Jeroen Demeyer | Dieter Crisman
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/16640 | 3852a0a23966400e02a14512e97e8ae46e45ec2a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
Comment:
And I am happy with everything except I need to look at the very last
patch one more time... okay, looks good other than two questions.
Question - is this a Python syntax I'm not aware of?
{{{
def show(self, *, filename=None, **kwds):
}}}
In particular, the extra `*` mystifies me. (Edit - okay, I found it, but
it appears to be Python 3 only? I believe it works in recent Python 2.x
since you used it, but I couldn't find a definitive reference - even the
Python reference was ambiguous.)
Oh, and maybe add a doctest for
[http://git.sagemath.org/sage.git/commit/?h=3852a0a23966400e02a14512e97e8ae46e45ec2a&id=bd1479d38fe1adb42755ab92499ff8c1ba35592d
this commit] with the error raised? Maybe that's too trivial to do... but
for some reason the doctest
{{{
sage: p.show(viewer='canvas3d')
}}}
doesn't raise an error, which makes sense because of the code. But it
''also'' is now doctested with the
[http://git.sagemath.org/sage.git/commit/?id=bd1479d38fe1adb42755ab92499ff8c1ba35592d
most recent change] you made, despite what you just said earlier that
making canvas3d guys was too long!
Somehow this should be resolved. I think the best way is to doctest the
''creation'' of the file, perhaps by setting a one-time flag or something,
rather than the error - as long as we tell people that in the command line
it will give an error. (Well, we could doctest both as well!)
--
Ticket URL: <http://trac.sagemath.org/ticket/16640#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
