#17298: Adding Graded/Weighted Hilbert Series Functionality to Sage
-------------------------------------+-------------------------------------
       Reporter:  john_perry         |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  commutative        |   Resolution:
  algebra                            |    Merged in:
       Keywords:  Hilbert Series,    |    Reviewers:  Travis Scrimshaw
  weighted, singular                 |  Work issues:
        Authors:  John Perry         |       Commit:
Report Upstream:  N/A                |  40d897b5c3419c8de07978be965e6c3e9c078b98
         Branch:                     |     Stopgaps:
  public/ticket/17298-graded_hilbert_series|
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by john_perry):

 * status:  needs_review => positive_review


Comment:

 Replying to [comment:23 tscrim]:
 > However the traceback tells you where the error occurred: ...
 > {{{
 > TypeError: Grading must be a list or a tuple of integers.
 > }}}
 > I believe the error message should be concise and not repeat information
 (plus I think most error messages in Sage/python don't tell you this info
 and rely on the traceback).

 OK, I think I had confused this type of error message with another (e.g.,
 I'm working with a Cython program, and it doesn't usually tell you where
 something happened). I'll give it a positive review.

 Thank you very much for the help w/improving this patch. :-)

--
Ticket URL: <http://trac.sagemath.org/ticket/17298#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to