#17245: Matrix class __init__ for sparse matrices is incorrectly documented
-------------------------------------+-------------------------------------
       Reporter:  darij              |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  linear algebra     |   Resolution:
       Keywords:  matrices,          |    Merged in:
  documentation,                     |    Reviewers:
        Authors:  Darij Grinberg     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/matrix      |  a74bc0cc7b98f429d69c4bdc842bcb3866ff077e
  /doc-input-matrix-class            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Description changed by darij:

Old description:

> It claims to take a list of triples `(i, j, entry in row i and column
> j)`, but it actually takes a dictionary `(i, j): entry in row i and
> column j`.
>
> I have fixed the error where it appears (integer, rational and mod-n
> matrices). It would also be good to copy this documentation to other
> classes where it makes sense.

New description:

 It claims to take a list of triples `(i, j, entry in row i and column j)`,
 but it actually takes a dictionary `(i, j): entry in row i and column j`.

 I have fixed the error where it appears (integer, rational and mod-n
 matrices). Are there any other classes where this doc makes sense?

 EDIT: Now that I am looking at this again, it worries me that matrix
 classes for matrices over QQ, ZZ and Zmod(n) ignore the `coerce` and
 `copy` attributes. The idea might be that integers, rationals and ints mod
 n do not need to be coerced -- but I don't think this is the case
 (particularly ints mod n); and that integers, rationals and ints mod n do
 not need to be copied because they are already immutable -- but the `copy`
 attribute does not copy the entries, but copies the *list/dict* of
 entries, and that is always mutable.
 This is not fixed here.

--

--
Ticket URL: <http://trac.sagemath.org/ticket/17245#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to