#17308: Fix sws2rst
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: scripts | Resolution:
Keywords: | Merged in:
Authors: Karl-Dieter | Reviewers: Jeroen Demeyer, Karl-
Crisman, Jeroen Demeyer | Dieter Crisman
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17308 | 6eed79ee5a93f42f10389978370ba4994a3d8a02
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Karl-Dieter Crisman, Jeroen Demeyer', 'oldvalue':
u'Karl-Dieter Crisman'}):
* reviewer: => Jeroen Demeyer, Karl-Dieter Crisman
* author: Karl-Dieter Crisman => Karl-Dieter Crisman, Jeroen Demeyer
Comment:
> I ended up changing a lot of the sage-sws2rst script, but I think it is
better now and less prone to breakage. If you agree, you can set this to
positive_review.
Yes, and you can add yourself to the author log too since you added me.
Regarding your original remark
{{{
This strange assumption should also be removed:
Remark:
The sws file(s) should be in the current directory; using an
absolute path will result in an error."""
}}}
see [comment:39:ticket:10637 here] and [comment:65:ticket:10637 here] -
and Pablo said he did it, but somehow it didn't make it in. But it
turned out that switching to `mkdtemp()` completely removed the problem
anyway, since the only place two paths were joined (as opposed to a path
and a string like `'data'`, or something from a list of a directory) was
there. So you were okay to remove that, and I have tested it with the
latest version.
> I cannot see how this move could generate an error which can be ignored,
so I removed the exception handling.
How about a permissions error or something about too big of a file, or
weird characters, or...? (Just brainstorming.) That could be safely
ignored; in the event of emergency, just don't copy that particular file,
I guess that was the thinking. Because after all otherwise you could
never really use sws2rst at all on that worksheet. Because of this, and
because this was in the very first version Pablo put up, so I'm reluctant
to have it removed.
Otherwise all should be well.
--
Ticket URL: <http://trac.sagemath.org/ticket/17308#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
