#13993: Implementation of plotting cover labels for posets
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
stumpc5 | Status: positive_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Nathann Cohen
combinatorics | Work issues:
Keywords: poset | Commit:
Authors: | 6c263fd19cac2f03cab18ddf9bc7141dd1a76851
Christian Stump | Stopgaps:
Report Upstream: N/A |
Branch: |
u/chapoton/13993 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Hello again !
The branch looks good.
There are many functions in the graph code that are meant to associate
values to the edges, and we never exactly know whether we should only
accept dict-only input and ask the user to convert his to that, or if we
should do what you did, i.e. reproduce almost the same code for all
different inputs.
Perhaps in this case it is more justified than in others, as it is a very
simple function (plot) that beginners will probably use too.
Anyway. Good to go.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/13993#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
