#15247: Introduce a baseclass for singletons
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: performance | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers: Marc Mezzarobba,
Report Upstream: N/A | Travis Scrimshaw
Branch: | Work issues:
public/singleton_class-15247 | Commit:
Dependencies: | 3e9e736a9fbe164d07a2ce1d58efdc3e5b2a49ab
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
I just had a look at 0d78737, and it looks good to me.
I would have two semi-unrelated suggestions though:
- Maybe rename the class to `Singleton` rather than `SingletonClass`: then
the name of the class will describe, as is usual, what its instances are,
rather than the class itself.
- For the test that is modified in 0d78737: make the inheritance explicit
by creating a subclasss rather than trigerring such an inheritance through
a call to _refine_category.
Thanks!
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/15247#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
