#6468: [with patch; needs work] FiniteField_prime_modn.__call__ should raise an
error, rather than return an error
------------------------------+---------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: basic arithmetic | Keywords: Finite field, call
Reviewer: | Author: Simon King
Merged: |
------------------------------+---------------------------------------------
Comment(by SimonKing):
Replying to [comment:2 was]:
> REFEREE REPORT:
>
> * Put in an example in the patch that clearly illustrates that you've
fixed the bug. I.e., write some code that raises that exception, and
illustrate that it is raised. Put this in the TESTS: section of the
tests.
I'd be happy to do so. But it turns out that it is not easy to make
{{{integer_mod.IntegerMod(self, x)}}} raising a {{{NotImplementedError}}}
or a {{{PariError}}}. By accident, I found that this is the case when
using my extension class for describing elements of modular polynomial
rings of finite p-groups. But certainly items from a to-be-created-and-at-
most-optional package can't be part of a doc test...
I try to cook something else up that triggers the error. But perhaps you
now better how to produce a PariError?
Anyway, since currently the call method has no doc test at all, it is
certainly wise to create one.
Best regards
Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6468#comment:3>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
