#10483: Deprecate the misuse of symbolic variables as polynomial variable
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:  AlexGhitza
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  basic arithmetic   |   Resolution:
       Keywords:  deprecation        |    Merged in:
  symbolic polynomial variable       |    Reviewers:  Karl-Dieter Crisman
        Authors:  Simon King, Ralf   |  Work issues:
  Stephan                            |       Commit:
Report Upstream:  N/A                |  7874bd347acdcc1f5b6683c53f6021a623dbb4ac
         Branch:  public/10483-2     |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 In various places in the library files, you manually call `R[repr(x)]` or
 `R[str(x)]`. Is that really needed? Maybe in some cases it is justified,
 but you need to convince me.

 Then some details:
 {{{
 x, y = 'x', 'y'
 }}}
 is confusing, just use `'x'` and `'y'` instead of `x` and `y`.

 Replace
 {{{
 R = PolynomialRing(GF(2)['x'])
 }}}
 by
 {{{
 R = PolynomialRing(GF(2), 'x')
 }}}

 Change
 {{{
 from sage.misc.misc import deprecation
 ...
 if do_something_deprecated():
     deprecation(..)
 }}}
 to
 {{{
 ...
 if do_something_deprecated():
     from sage.misc.misc import deprecation
     deprecation(..)
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/10483#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to