#16603: permanental_minor_vector, matching polynomial
-------------------------------------+-------------------------------------
       Reporter:  pernici            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Mario Pernici      |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/pernici/ticket/16603             |  947ddd16da731019f25a951e43bf551ad997a700
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => needs_work


Comment:

 Hello,

 This code is very cool! You can have a look at my branch
 `u/vdelecroix/16603` where I provide two commits that I describe below.

 - I edited a bit the code, I hope it is cleaner (and actually also a bit
 faster)

 - Please, could you fill the section `ALGORITHM` of
 `permanental_minor_vector`. It would be nice to have here a rough
 description of the algorithm.

 - I edited a lot the documentation. First of all the file `matrix_misc.py`
 was not part of the matrix documentation! After my commits it is. If you
 compile the documentation (with either `make doc` or `sage -docbuild
 reference html`) then you will see the result in the section `Matrices and
 Spaces of Matrices` -> `Miscellaneous matrix functions`. I changed the
 name `_prm_mul` to `prm_mul` in order to make it appear in the
 documentation.

 - Currently the situtation for benchmarks is unfair:
    - the code of Jaap Spies to compute the permanent and the permanent
 minors can be optimized a lot!
    - your code is in Python while Jaap's one is in Cython

 - As you mentioned this algorithm can be used in several contexts. It
 would be nice to have some methods (of graphs and matrices) that call it.
 But if you prefer, we can do it in a further ticket.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16603#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to