#17408: Faster transitive_reduction (=> faster Poset creation)
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  graph theory       |   Resolution:
       Keywords:  poset              |    Merged in:
        Authors:  Nathann Cohen      |    Reviewers:  Frédéric Chapoton
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/17408                |  858d7a9197144ee878bbe1c5b9687c4b12662143
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => positive_review
 * reviewer:   => Frédéric Chapoton


Comment:

 Helloooooo !

 > There was a failing doctest, because undirected graphs do not have a
 is_directed_acyclic method.

 Oh, I see. Thanks ! `;-)`

 > I have also made a few pep8 changes.

 You should see a doctor about that `:-P`

 > Looks good to me. You can set a positive review if you agree with my
 changes.

 Thanks again ! `:-)`

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17408#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to