#2891: inline_fortran -- completely rewrite to not save a global variable and
*not* got hacked into various global structures all over
-------------------------------+--------------------------
Reporter: was | Owner: cwitty
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: misc | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------+--------------------------
Old description:
> The InlineFortran stuff in misc/inline_fortran.py is bad. That global
> variable should be explicitly passed into the __eval__ and __call__
> methods, and should *not* be set on creation. I've attached what the
> file *should* roughly be, but I can't get it to work.
>
> Also, it's terrible the hacking in server/support.py to get the fortran
> stuff in there. This is just really wrong.
>
> NOTE -- this all works -- it's not a bug. It's just not good
> programming.
New description:
The `InlineFortran` stuff in `src/sage/misc/inline_fortran.py` is bad.
That `globals` variable should be explicitly passed into the `eval` and
`__call__` methods, and should *not* be set on creation. I've attached
what the file *should* roughly be, but I can't get it to work.
Also, it's terrible the hacking in `sagenb` to get the fortran stuff in
there. This is just really wrong.
NOTE -- this all works -- it's not a bug. It's just not good programming.
--
Comment (by jdemeyer):
Replying to [comment:8 kcrisman]:
> Hey Jeroen, you worked on several related tickets like #13992 and #13887
- is this ticket even needed at this point?
For sure, the issue that this ticket talks about (the `globals` variable)
hasn't been changed.
--
Ticket URL: <http://trac.sagemath.org/ticket/2891#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
