#17443: abs(matrix) should not be a shortcut for det
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17443 | e6a4de841482f86499d6ae16769e6a220624b3a6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Passes all tests, so positive review.
Do you know of a tool to detect that you only "moved" the code of those
two big functions ?
I found no way to do this, so in order to check your patch I moved what
you wrote in matrix2 back to matrix_dense, only to see as it was detected
as "leaving those function as they were" when merged with your patch.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17443#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
