#16964: Speed up comparisons in QQbar
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-6.5
Component: number fields | Resolution:
Keywords: variety qqbar cmp | Merged in:
singular | Reviewers:
Authors: Martin von Gagern | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9f6fdc209d62e055df4bdd38f9f946332fbf3842
u/gagern/ticket/16964 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Martin von Gagern', 'oldvalue': ''}):
* status: new => needs_review
* commit: => 9f6fdc209d62e055df4bdd38f9f946332fbf3842
* author: => Martin von Gagern
Comment:
Here is my first stab at the approach outlined in comment:3. If you have a
nicer way to handle things, feel free to suggest an alternative. If you
think that my special case should not call `minpoly()` but instead examine
whether the descriptor is `ANRoot` with matching polynomial, please state
your reason for this argument. Likewise, if you think I should also handle
more than one real value or conjugate pair for a given real component,
then I'd love to hear how you'd implement this without making the code too
hard to read and maintain.
As it is, I consider my code not particularly beautiful, and perhaps not
the best solution either, but it is ''way'' better than the current state
of affairs, and since we have other things depending on this, e.g. #14239,
I'd like to see this merged pretty soon and possible improvements dealt
with in a later ticket.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=9f6fdc209d62e055df4bdd38f9f946332fbf3842
9f6fdc2]||{{{Faster qqbar comparison for case with equal minpoly.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16964#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
