#17082: Fix height_difference_bound to work over Number Fields
-------------------------------------+-------------------------------------
Reporter: jdefaria | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Ben Hutz
Authors: Joao de Faria | Work issues:
Report Upstream: N/A | Commit:
Branch: | 09349098e9a50e01761b46402198c40ba3becd3c
u/jdefaria/ticket/17082 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_work
* reviewer: => Ben Hutz
Comment:
Well, a couple things here. This passes all the long tests, and the
functionality change seems ok. However, there are two things that should
be fixed.
- There is an indentation issue with the new example you added.
- you seems to restrict to number fields or ZZ. If it is ZZ the code
changes the ring to QQ so that .lift() works. Why can't you do this for
any number field ring (change to its field of fractions)?
--
Ticket URL: <http://trac.sagemath.org/ticket/17082#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
