#16603: permanental_minor_vector, matching polynomial
-------------------------------------+-------------------------------------
Reporter: pernici | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Mario Pernici | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/16603 | 3e7297b35f94986b8e0f37f30a3b3d6ee3d3b699
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* commit: 19350a4574f4caa2e0b5ad08f66e51930b647a42 =>
3e7297b35f94986b8e0f37f30a3b3d6ee3d3b699
* branch: u/pernici/ticket/16603 => u/vdelecroix/16603
* reviewer: => Vincent Delecroix
Comment:
Hello,
I really think that the documentation is half of a software: it provides
specification of functions and help the user to orient himself/herself.
Next time you implement a function in Sage pay attention that your new
functionality is referenced from other part of the code and that it also
make references to relevant functions. There is a lot of possibilities for
organization of the documentation (see the
[http://sagemath.org/doc/developer/coding_basics.html#docstring-markup-
with-rest-and-sphinx section "Docstring" of the developer guide]).
I was not happy with the current behavior and documentation of
`rook_vector` and `permanental_minor` (these methods should work for
rectangular matrices whatever their shape). I guess that this is my last
commit for that ticket. Just have a look and if you agree we can set the
ticket to positive review.
Next step would be optimisation of Ryser algorithm: #17457.
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3e7297b35f94986b8e0f37f30a3b3d6ee3d3b699
3e7297b]||{{{trac #16603: documentation commit}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16603#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
