#17526: Bitset doctest failures on OS X
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.5
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17526 | 0d1e1497735026f12f1cb06c5ef919f462d0bd23
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* reviewer: => Simon King
Comment:
Replying to [comment:6 jdemeyer]:
> You really need 3 cases, otherwise the comment {{{note that r.limbs -
shifted_limbs >= 1}}} becomes false.
... and ">=1" is needed, since `mpn_zero` can only zero a 'positive'
number of limbs, right?
> Moreover, the case `shifted_limbs == r.limbs` requires `bitset_fix()` in
general.
Also correct.
OK, my questions are answered. I can not test if the branch fixes the
problem on OSX. But the code looks good. If someone (John?) can confirm
that it works on OSX, please feel free to switch to positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/17526#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
