#17453: fix category for integer mod rings
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers: Ben Hutz
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/categories/integer_mod_rings-17453|
61ceeeb29b6b5e438322c88014e87d5bbe091d30
Dependencies: #17501 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
Comment:
Replying to [comment:3 bhutz]:
> This does appear to fix the category issues for integer_mod_rings. But
there is one minor issue and something I'm not sure about which is
probably just my lack of knowledge.
>
> The minor issue is a doc test failure in
sage/rings/finite_rings/integer_mod_rings.py. It is just a typo where the
expected value should be `True` but `False` was put in the doctest for
`Zmod(5)`.
Fixed.
> The part that is not clear to me is why in `_contains_helper(cls)` you
are able to use `cls` as a callable object as
`Category_contains_method_by_parent_class(cls())`. Isn't `cls` something
like `Zmod(7)`?
No it's not. It is the class `Rings` (not an instance); so in effect,
`cls()` is doing `Rings()` and creating an instance of that class. Does
that clarify things?
--
Ticket URL: <http://trac.sagemath.org/ticket/17453#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
