#17452: LinearCode should check the rank
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/17452                 |  173f3ece741427bbc40f3f91305e0a14391ea7fb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Wow. Thank you for fixing that and cleaning the code a bit, it was really
 ugly. It took me a long time only to understand what it did, and I had
 your commit to help me `O_o`

 I do not get why that code would return a `d` equal to zero, however...
 What is the meaning of that ?

 It is not really a problem for the review, that's what the code deals with
 already... But I would be glad to understand.

 I would also be glad to understand why the GAP function is so complicated
 and takes this 'i' as a parameter, but well `O_o`

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17452#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to