#16399: Matrix stack doesn't coerce to a common parent
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: coercion | Resolution:
Keywords: matrix stack | Merged in:
coercion | Reviewers:
Authors: Frédéric | Work issues:
Chapoton, Jeroen Demeyer | Commit:
Report Upstream: N/A | e3d7bbd479838b2cbc8433509034da0ab864d456
Branch: | Stopgaps:
u/jdemeyer/ticket/16399 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Looks good overall, but there are two things.
The first is could you keep the "returns a new matrix" part of the
documentation? Since matrices are mutable, your proposed change makes the
result slightly ambiguous to me as we could mutate in place and return
`self`.
Second is about this change:
{{{#!diff
diff --git a/src/sage/modules/fg_pid/fgp_morphism.py
b/src/sage/modules/fg_pid/fgp_morphism.py
index 80fe02b..86bbe37 100644
--- a/src/sage/modules/fg_pid/fgp_morphism.py
+++ b/src/sage/modules/fg_pid/fgp_morphism.py
@@ -423,6 +423,7 @@ class FGP_Morphism(Morphism):
# Stack it on top of the basis for W'.
Wp = CD.V().coordinate_module(CD.W()).basis_matrix()
+ Wp = Wp.change_ring(A.base_ring())
B = A.stack(Wp)
# Compute Hermite form of C with transformation
}}}
Is this necessary for this ticket or is it suppose to be a part of #17585?
--
Ticket URL: <http://trac.sagemath.org/ticket/16399#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
