#6514: [with patch, needs work] Boolean function for cryptography
--------------------------+-------------------------------------------------
Reporter: ylchapuy | Owner: somebody
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.1
Component: cryptography | Keywords: boolean function, cryptography
Reviewer: | Author: Yann Laigle-Chapuy
Merged: |
--------------------------+-------------------------------------------------
Comment(by malb):
'''Review'''
* typo: "This module allow" -> allows
* it would be nice to have docs for {{{walsh}}}, {{{yellow_code}}},
{{{reed_muller}}}
* maybe replace "BooleanPolynomial" with
":class:`sage.rings.polynomial.pbori.BooleanPolynomial`" which adds a link
in the reference manual
* {{{if isinstance(x, list)}}} could be changed to {{{if isinstance(x,
(list,tuple,GeneratorType)}}} to be less dependent on the type, you'll
need to {{{from types import GeneratorType}}}
* is it wanted that these don't have a type? {{{cdef _walsh_transform,
_nvariables, _big_endian, _nonlinearity}}}
* typo: "table truth" -> "truth table"
* cmp doesn't have a proper doctest
* Maybe put the world "True" in "``True``" ?
* Should() popcount() really return a Python int instead of a Sage
integer?
* Patch applies without error but with some fuzz against 4.1 (this isn't
an issue)
* Doctests pass.
* Reference manual builds without warning.
* Reference manual looks good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6514#comment:2>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
