#6461: [with patch, needs work] Schaefer's Simplified Data Encryption Standard
for
educational purposes
--------------------------+-------------------------------------------------
Reporter: mvngu | Owner: somebody
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.1
Component: cryptography | Keywords: cryptography, DES, S-DES
Reviewer: | Author: Minh Van Nguyen
Merged: |
--------------------------+-------------------------------------------------
Comment(by malb):
'''Review''':
* I assume that the specification implemented is correct, I didn't check
against the paper, are there official test vectors?
* The code looks good and is nicely documented (coverage: 100%)
* {{{__cmp__}}} expects you to return an integer (-1,0,1) and not
{{{True}}} or {{{False}}}, cf.
http://docs.python.org/reference/datamodel.html
* it is a bit confusing that P is often the plaintext (cf. C for
ciphertext) and the permutation, but that might be a problem in the paper
* it would be nice to have an {{{sbox(n)}}} function to return the
S-Boxes 0 and 1
* patch applies cleanly against 4.1.
* reference manual builds without warnings and the result looks okay.
* doctests pass on sage.math
Bottomline: positive review except some nitpicks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6461#comment:2>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
