#5133: [with patch, needs work] improve the coverage of ext/multi_modular.pyx
from
an abysmal 0% to something more respectable
----------------------------+-----------------------------------------------
Reporter: was | Owner: burcin
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: linear algebra | Keywords:
Reviewer: | Author: Burcin Erocal
Merged: |
----------------------------+-----------------------------------------------
Comment(by malb):
'''Review'''
* typo: {{{l_bound}}} -> {{{u_bound}}} in docstring
* the string representation is quite unusual, not sure if that's desired.
* {{{isinstance(val, list)}}} should allow more types {{{isinstance(val,
(list,tuple,GeneratorType))}}}
* Why is it okay to use {{{proof=False}}} for random integers, because
they are so small anyway? That should be added as a comment.
* {{{__cmp__}}} wants you to return -1,0,1 and not {{{True}}} or
{{{False}}}, cf. http://docs.python.org/reference/datamodel.html
* {{{INPUT::}}} -> {{{INPUT:}}}, it doesn't get two : because the
following block is not literal
* patch applies cleanly against 4.1
* doctest failures:
{{{
sage -t devel/sage/sage/modular/modsym/heilbronn.pyx # 1 doctests
failed
sage -t devel/sage/sage/modular/modsym/subspace.py # 12 doctests
failed
sage -t devel/sage/sage/modular/modsym/space.py # 9 doctests
failed
sage -t devel/sage/sage/modular/modform/eisenstein_submodule.py #
2 doctests failed
sage -t devel/sage/sage/modular/modform/space.py # 3 doctests
failed
sage -t devel/sage/sage/modular/hecke/degenmap.py # 1 doctests
failed
sage -t devel/sage/doc/en/bordeaux_2008/elliptic_curves.rst # 5
doctests failed
sage -t devel/sage/sage/modular/modsym/ambient.py # 3 doctests
failed
sage -t devel/sage/sage/modular/hecke/element.py # 1 doctests
failed
sage -t devel/sage/sage/modular/hecke/hecke_operator.py # 1
doctests failed
sage -t devel/sage/sage/modular/abvar/homology.py # 4 doctests
failed
sage -t devel/sage/sage/modular/abvar/morphism.py # 1 doctests
failed
sage -t devel/sage/sage/modular/hecke/module.py # 3 doctests
failed
sage -t devel/sage/sage/modular/abvar/torsion_subgroup.py # 4
doctests failed
sage -t devel/sage/sage/modular/hecke/submodule.py # 4 doctests
failed
sage -t devel/sage/sage/modular/abvar/abvar.py # 10 doctests
failed
sage -t devel/sage/sage/modular/modform/element.py # 1 doctests
failed
sage -t devel/sage/sage/modular/abvar/homspace.py # 4 doctests
failed
sage -t
devel/sage/sage/combinat/symmetric_group_representations.py # 1 doctests
failed
sage -t devel/sage/sage/geometry/lattice_polytope.py # 15
doctests failed
sage -t devel/sage/sage/schemes/elliptic_curves/padic_lseries.py
# 12 doctests failed
sage -t devel/sage/sage/schemes/elliptic_curves/sha_tate.py # 6
doctests failed
sage -t
devel/sage/sage/schemes/elliptic_curves/ell_modular_symbols.py # 4
doctests failed
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5133#comment:2>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
