#17648: Move from_* functions from Partitions to Partitions_all
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.5
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | d37d47d4cc77f318e8bcc21cc69558411458c248
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/17648 |
Dependencies: |
-------------------------+-------------------------------------------------
Old description:
> Those functions do not depend on the parameters given to the `Partitions`
> constructor, i.e.:
>
> {{{
> sage:
> Partitions(5,length=2).from_frobenius_coordinates(([6,3,2],[4,1,0]))
> # does not read the input of Partition at all
> [7, 5, 5, 1, 1]
> }}}
>
> They should belong to `Partitions_all`
>
> Nathann
New description:
The following functions do not depend on the parameters given to the
`Partitions` constructor:
{{{
from_frobenius_coordinates
from_beta_numbers
from_exp
from_zero_one
from_core_and_quotient
}}}
Example:
{{{
sage: Partitions(5,length=2).from_frobenius_coordinates(([6,3,2],[4,1,0]))
# does not read the input of Partition at all
[7, 5, 5, 1, 1]
}}}
They should belong to `Partitions_all`, and thise branch moves them there.
Nathann
--
Comment (by ncohen):
Hello,
> What are "those functions"? Can you be more specific in your ticket
description?
My excuses. I thought that this would be clear from the diff, but when you
reverse A and B in a file, it is true that git can chose to "remove A and
add it somewhere else" or "remove B and add it somewhere else". I just
updated the description to say that the three functions I moved are the
following:
{{{
from_frobenius_coordinates
from_beta_numbers
from_exp
from_zero_one
from_core_and_quotient
}}}
> Also, it looks like you just moved code. Is that what you intended? No
new tests etc??
I did not think that there was any need to. The doctests were correct and
called `Partitions().from_...`. That command remains valid. On the other
hand, `Partition(5)` is now invalid.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17648#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
