#17652: Difference matrix product
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17652       |  7ceb954856dfdaa05c1918d49bcb4957624f0fcd
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_work


Comment:

 Hellooooooooooooo !!

 Several comments:

 - It's a pity to do the computations twice when lmbda1=lmbda2 (g1~g2
   symmetry). But perhaps that does not matter considering the timings
 involved.

 - The comment on the infinite loops does not match the code that follows
 (the
   code is right)

 - Why a {{{M = zip(*M)}}}? Isn't it better to change the loop above in
 order to
   compute the right matrix?

 - The new doctest {{{designs.difference_matrix(56,None,existence=1)}}}
 returned
   the same answer in the latest beta. Did you mean to test the new
 construction?

 - Could you write an INPUT section for the two functions?

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17652#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to