#17649: Kirkman Triple Systems (end of the construction)
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17649-bis   |  f6c2af6ce39ed44e45607647c67ca724ac283e87
   Dependencies:  #17612             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * commit:  79831523ba0fa8074f055647191ad3c6b49da324 =>
     f6c2af6ce39ed44e45607647c67ca724ac283e87
 * branch:  public/17649 => public/17649-bis


Comment:

 Hi Nathann,

 I did not feel very well with one line which mixes `sorted`, `enumerate`
 and `set`. I propose a commit to split them into several lines. Doing so,
 the code is also faster since there is less copy and sort.

 What do you think?

 Vincent
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=df628e9fc45c22fdc4bcca35466a4a9e5f7c1e25
 df628e9]||{{{trac #17649: formatting and documentation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f6c2af6ce39ed44e45607647c67ca724ac283e87
 f6c2af6]||{{{trac #17649: split complicated lines}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/17649#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to