#6355: [with SPKG, needs work] Cliquer to compute maximum cliques
---------------------------+------------------------------------------------
 Reporter:  ncohen         |       Owner:  rlm                
     Type:  enhancement    |      Status:  new                
 Priority:  major          |   Milestone:                     
Component:  graph theory   |    Keywords:  Clique max, Cliquer
 Reviewer:  Robert Miller  |      Author:  Nathann Cohen      
   Merged:                 |  
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Robert Miller
  * author:  ncohen => Nathann Cohen


Comment:

 Nathann,

 This is great work! However, you are still hard-coding some Linux-isms in
 spkg-install:

 {{{
 scons && cp Build/libcliquer.so "$SAGE_LOCAL/lib/"
 }}}

 Unfortunately, on OS X, it is `libcliquer.dylib` that is built by SCons.
 Why don't you copy `Build/*` over, to include all cases? You should also
 delete the commented part from spkg-install. While I'm reviewing, you need
 a Mercurial repository in the base directory of the spkg, and the License
 section of SPKG.txt needs to be clarified (i.e. GPLv2+).

 Keep up the good work!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6355#comment:6>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to