#17489: remove redundant factorial() from rings/arith.py
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: symbolics | Resolution:
Keywords: integer symbolic | Merged in:
function | Reviewers: Jeroen Demeyer
Authors: Ralf Stephan | Work issues:
Report Upstream: N/A | Commit:
Branch: public/17489 | 284470b209259928714b0ff91ac6f5b86746b157
Dependencies: #17531 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by rws):
Replying to [comment:36 tscrim]:
> I'm not completely sure about changing the test in
`finite_enumerated_sets` to also allow for `int`'s as the (untrained) user
might unexpectedly do a division and get 0 but is expecting a fraction. I
think the better solution is to actually change the output of the
`cardinality` to be in `ZZ`, and I'll be happy to make this change. (In
fact, I think a doctest in that file is going to fail because of this
change.)
Sorry to have been unresponsive. Please go ahead with your plan. Can I
consider my code part to be reviewed with this?
--
Ticket URL: <http://trac.sagemath.org/ticket/17489#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
