#6666: Implement analytic modular symbols for elliptic curves
-------------------------------------+-------------------------------------
Reporter: was | Owner: was
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.4
Component: modular forms | Resolution:
Keywords: period, modular | Merged in:
symbol | Reviewers: Frédéric Chapoton,
Authors: William Stein, | Peter Bruin
Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: public/6666 | dcaefdc03a500b6dcc9e3d683e7dc4bfd7e8a685
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:22 chapoton]:
> Looks good to me.
Thanks for the review!
> I allowed myself a few minor changes.
I'm not disputing your changes to the whitespace here, but note that PEP 8
does not say that there should be spaces around ''all'' operators, only
the relational ones. From https://www.python.org/dev/peps/pep-0008/:
>> If operators with different priorities are used, consider adding
whitespace around the operators with the lowest priority(ies). Use your
own judgment; however, never use more than one space, and always have the
same amount of whitespace on both sides of a binary operator.
>> Yes:
>> {{{
>> i = i + 1
>> submitted += 1
>> x = x*2 - 1
>> hypot2 = x*x + y*y
>> c = (a+b) * (a-b)
>> }}}
>> No:
>> {{{
>> i=i+1
>> submitted +=1
>> x = x * 2 - 1
>> hypot2 = x * x + y * y
>> c = (a + b) * (a - b)
>> }}}
Actually, in the case of `c = ...`, I would personally prefer the "no"
option or even `(a + b)*(a - b)`, which is closer to standard mathematical
typesetting, but in any case this is a matter of taste.
--
Ticket URL: <http://trac.sagemath.org/ticket/6666#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
