#17665: Change binary_matrix data type to use bitset
-------------------------------------+-------------------------------------
Reporter: dcoudert | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: misc | Resolution:
Keywords: | Merged in:
Authors: David Coudert | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17665 | 5cc5d22f48de853f3775e459afed1b5bc99170c9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
I added a small commit at `public/17665` that only fixes some doc and a
function call. It is not equivalent to do the following change:
{{{
#!diff
- binary_matrix_set0(m,row,col)
- m.rows[row][col >> index_shift] |= (<unsigned long>1) << (value &
offset_mask)
+ if value:
+ binary_matrix_set1(m,row,col)
+ else:
+ binary_matrix_set0(m,row,col)
}}}
The purpose of the first code (and of `bitset_set_to` is specifically to
avoid that 'if').
Nothing else to mention, and only my commit now needs a review!
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17665#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
