#17727: Remove redundant parent_c() functions
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17727 | 3547ea8990d2c2f76001df02dac213956c515e07
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
According to Python documentation
{{{
int PyNumber_Check(PyObject *o)
Returns 1 if the object o provides numeric protocols,
and false otherwise. This function always succeeds.
}}}
So even sage integers, floating points numbers and many others will answer
true to that (I checked). And from the specification I do not see how such
test can be fast. I do not have anything against using `PyNumber_Check`
but the associated comment is definitely not appropriate.
Related question: why should we check for a method `.parent()`? Would the
following be invalid?
{{{
cdef parent_c(x):
if isintance(x, Element):
return (<Element> x)._parent
else:
return type(x)
}}}
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17727#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
