#11095: Add BMSS algorithm for isogenies of elliptic curves
-------------------------------------+-------------------------------------
       Reporter:  defeo              |        Owner:  cremona
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  elliptic curves    |   Resolution:
       Keywords:  isogenies ecc2011  |    Merged in:
        Authors:  Luca De Feo        |    Reviewers:  John Cremona, Marco
Report Upstream:  N/A                |  Streng
         Branch:                     |  Work issues:  merge conflicts
  public/ticket/11095                |       Commit:
   Dependencies:                     |  d88217455f757053cd032671ccfb3688fea5dc31
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by pbruin):

 For this part of the last commit
 {{{
 #!diff
 --- a/src/sage/schemes/elliptic_curves/ell_curve_isogeny.py
 +++ b/src/sage/schemes/elliptic_curves/ell_curve_isogeny.py
 @@ -3441,13 +3436,14 @@ class EllipticCurveIsogeny(Morphism):
  aut = [a for a in auts if a.u == sc]
  if len(aut) != 1:
      raise ValueError("There is a bug in dual().")
 + # PROBLEM HERE BELOW IN THE CODE : E0 not defined !
  phi_hat.set_post_isomorphism(WeierstrassIsomorphism(E0,aut[0],E0))
  self.__dual = phi_hat

 }}}
 see #17293, where I also noticed this problem; the correct line is
 {{{
 phi_hat.set_post_isomorphism(aut[0])
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/11095#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to