#17584: Simplify numpy import in vectors
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.5
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/17584            |  35a6d5f36bc7fe4b511bb2fcd780e5b685852fe9
   Dependencies:  #13081             |     Stopgaps:
-------------------------------------+-------------------------------------
Description changed by jdemeyer:

Old description:

> In `src/sage/modules/vector_double_dense.pyx` there is a lot of code like
> {{{
>         global numpy
>         if numpy is None:
>             import numpy
> }}}
>
> However, since the whole module is not imported at startup, we might as
> well just put a global
> {{{
> cimport numpy
> import numpy
> }}}
> and be done with it.

New description:

 In `src/sage/modules/vector_double_dense.pyx` there is a lot of code like
 {{{
         global numpy
         if numpy is None:
             import numpy
 }}}

 However, since the whole module is not imported at startup, we might as
 well just put a global
 {{{
 cimport numpy
 import numpy
 }}}
 and be done with it (we really need both the `cimport` and the `import`
 since the `.pxd` file comes from Cython which declares only the C API, not
 all numpy Python functions).

--

--
Ticket URL: <http://trac.sagemath.org/ticket/17584#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to