#17735: runsnake() cleanup
-------------------------------------+-------------------------------------
       Reporter:  tmonteil           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.5
      Component:  misc               |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/tmonteil/runsnake___cleanup      |  ecaf0528f278c20f6c6c7497d311f11594e8a02d
   Dependencies:  #9386, #14414      |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by nbruin):

 Looking at the implementation of sage.misc.sage_ostools.have_program, we
 might want to change:
 {{{#!diff
 -           if os.access(os.path.join(p, program), os.X_OK):
 +           pth=os.path.join(p, program)
 +           if os.isfile(pth) and os.access(pth, os.X_OK):
 }}}
 since `os.access(..., os.X_OK)` might return true for a directory and yet
 this would not be picked up as an executable by the operating system.

--
Ticket URL: <http://trac.sagemath.org/ticket/17735#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to