#16630: Fix category for finite Coxeter groups
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: group theory | Resolution:
Keywords: Coxeter, category | Merged in:
Authors: Travis Scrimshaw, | Reviewers: Darij Grinberg,
Frederic Chapoton | Frederic Chapoton, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/16630 | 02c4161a5a5eae6c5bff3aeee3e857ff22c9b422
Dependencies: #16633 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Travis Scrimshaw, Frederic Chapoton', 'oldvalue':
u'Travis Scrimshaw'}):
* reviewer: => Darij Grinberg, Frederic Chapoton, Travis Scrimshaw
* author: Travis Scrimshaw => Travis Scrimshaw, Frederic Chapoton
Comment:
LGTM modulo one minor change: when constructing `self._bilinear`, could we
divide by `base_field(-2)` instead of `base_ring(-2)` (since this coercion
will happen anyways)? Once this change is made, then you can set a
positive review on my behalf.
--
Ticket URL: <http://trac.sagemath.org/ticket/16630#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
