#16630: Fix category for finite Coxeter groups
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: group theory | Resolution:
Keywords: Coxeter, category | Merged in:
Authors: Travis Scrimshaw, | Reviewers: Darij Grinberg,
Frédéric Chapoton, Darij Grinberg | Frédéric Chapoton, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/groups/fix_category_finite_coxeter-16630|
49cc3bc1ecaba4b43f2ed426a8ebbfee6c77ddcd
Dependencies: #16633 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: d1b9211eb55403bbfad3fb23adf127a92447ffb1 =>
49cc3bc1ecaba4b43f2ed426a8ebbfee6c77ddcd
* branch: public/ticket/16630 =>
public/groups/fix_category_finite_coxeter-16630
Comment:
I renamed this method `order`, which is the real cause of the issue why
`cardinality` from `FiniteEnumeratedSets` isn't working properly (and
`order` raises a `NotImplementedError` where it shouldn't either). I also
refined the category to `Infinite` if the group is not finite.
Note that I cherry-picked your commits into this branch (since I don't
want to upgrade my copy of Sage today).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3597e2f5e65dd0f7b56a0464c5b36c416d99c61e
3597e2f]||{{{Merge branch
'public/groups/fix_category_finite_coxeter-16630' of
trac.sagemath.org:sage into
public/groups/fix_category_finite_coxeter-16630}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0f5d819446fdc4f0320f8ec6595dd272b1647d5d
0f5d819]||{{{trac #16630 replace base_ring by base_field}}}||
||[http://git.sagemath.org/sage.git/commit/?id=be4cdbf2caf74877439001591a8b6ffafc43c2a9
be4cdbf]||{{{trac #16630 adding a cardinality method.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=49cc3bc1ecaba4b43f2ed426a8ebbfee6c77ddcd
49cc3bc]||{{{Changed cardinality() to order() and added Infinite
refinement.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16630#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
