#16773: Analytic Rank Bound
-------------------------------------+-------------------------------------
Reporter: spice | Owner: spice
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.5
Component: elliptic curves | Resolution:
Keywords: elliptic curves, | Merged in:
analytic rank, l-functions | Reviewers: William Stein
Authors: Simon Spicer | Work issues:
Report Upstream: N/A | Commit:
Branch: | bbe851c24ed0cf48d1d746bcee4258e7394048ca
u/spice/analytic_rank_bound | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vbraun):
* Can you move `_sum_over_residues` out of the function body and document
it
* `_sum_over_residues` can clearly return `None` if it falls through the
last loop, which is the random error that we get. Can you start with an
`assert False` (good practice anyways) at the end of it and then try it
out with small residue chunks.
* addition is not associative, so parallel reductions always suffer from
numerical errors. but `10^-10 =~ 10^6 ulp` is ridiculously large.
* doctests are typically run in parallel with one per (virtual) cpu, using
@parallel is just slowing it down. Perhaps ncpus should generally return 1
or 2 in `DOCTEST_MODE`
* PEP8 whitespace style would be nice, e.g. space after comma `f(a, b,
foo=bar)`.
--
Ticket URL: <http://trac.sagemath.org/ticket/16773#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
