#5133: [with patch, needs review] improve the coverage of ext/multi_modular.pyx
from an abysmal 0% to something more respectable
----------------------------+-----------------------------------------------
Reporter: was | Owner: burcin
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: linear algebra | Keywords:
Reviewer: | Author: Burcin Erocal
Merged: |
----------------------------+-----------------------------------------------
Comment(by mvngu):
I got a hunk failure when applying {{{trac_5133-multi_modular_tests-
take2.patch}}}:
{{{
[mv...@sage sage-exp]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/5133/trac_5133-multi_modular_tests-take2.patch
adding trac_5133-multi_modular_tests-take2.patch to series file
[mv...@sage sage-exp]$ hg qpush -a
applying trac_5133-multi_modular_tests-take2.patch
patching file sage/rings/arith.py
Hunk #2 FAILED at 914
1 out of 4 hunks FAILED -- saving rejects to file sage/rings/arith.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
Errors during apply, please fix and refresh trac_5133-multi_modular_tests-
take2.patch
}}}
Here's the hunk that failed:
{{{
--- arith.py
+++ arith.py
@@ -915,6 +915,9 @@
the function uses a pseudo-primality test, which is much faster
for
really big numbers but does not provide a proof of primality. If
None, uses the global default (see sage.structure.proof)
+
+ - ``lbound`` - an integer >= 2
+ lower bound for the chosen primes
EXAMPLES::
}}}
This is because I previously applied the patches at #6529. The failure has
been manually resolved so the docstring of {{{random_prime}}} in
{{{sage/rings/arith.py}}} now reads:
{{{
Returns a random prime p between `lbound` and n (i.e. `lbound <= p <=
n`).
The returned prime is chosen uniformly at random from the set of prime
numbers less than or equal to n.
INPUT:
- ``n`` - an integer >= 2.
- ``proof`` - bool or None (default: None) If False, the function
uses a
pseudo-primality test, which is much faster for really big numbers
but
does not provide a proof of primality. If None, uses the global
default
(see :mod:`sage.structure.proof.proof`)
- ``lbound`` - an integer >= 2
lower bound for the chosen primes
}}}
The patch {{{trac_5133-take2-rebased.patch}}} is a rebase of {{{trac_5133
-multi_modular_tests-take2.patch}}} that depends on first applying the
patches at #6529.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5133#comment:5>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
