#17585: Implement coordinate_ring() for free module elements
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/17585            |  dbca6bb7915f3084b04af6943689ab0d244d7032
   Dependencies:  #17584, #17694,    |     Stopgaps:
  #13081, #12600                     |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:23 jdemeyer]:
 > Replying to [comment:22 vdelecroix]:
 > > 2. What is the point of the `ring` argument of `basis_matrix`?
 Moreover the implementation looks wrong since it returns the matrix `A`
 (defined over the `coordinate_ring`) as soon as `ring`  is the
 `base_ring`.
 > At one point during development of this ticket, I needed an explicit
 ring to work-around #16399. Instead, #16399 got fixed, so this work-around
 was no longer needed. I did keep the change to `basis_matrix()`. Does this
 extra argument really hurt? I could remove it if you want. The
 implementation is correct though: I think you are confusing the
 `base_ring` of the matrix with the `coordinate_ring` of the module.

 Could you at least include an example in the documentation?

--
Ticket URL: <http://trac.sagemath.org/ticket/17585#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to