#16976: Conjugacy classes and rational period functions for Hecke triangle
groups
-------------------------------------+-------------------------------------
Reporter: jj | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: modular forms | Resolution:
Keywords: hecke triangle | Merged in:
group conjugacy class rational | Reviewers: Vincent Delecroix
period function | Work issues:
Authors: Jonas Jermann | Commit:
Report Upstream: N/A | 6d7348137d982e27990088f352a5194fd967eefa
Branch: | Stopgaps:
u/vdelecroix/16976 |
Dependencies: #16936 |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
* commit: 9fabb44a5f893dbdcc91e13c818ac8b2b79dbbc0 =>
6d7348137d982e27990088f352a5194fd967eefa
* branch: u/jj/triangle_conjugacy => u/vdelecroix/16976
Comment:
I had to merge with 6.6.beta1 because of a trivial merge conflict due to
#17694
You should really think about cleaning before implementing anything else.
I already made many remarks about that are here are more:
1. The code of `MatrixGroupElement` is done in such way that there is no
need to write a custom `__init__`. You only need to implement a
`._matrix_check` in the parent.
2. There is a `.gitignore` file in `sage/modular/modform_hecketriangle/`
because of
{{{
commit c8cbd7acfc81bdc1c24684f26d986f59491e0a3a
Author: Martin Raum <[email protected]>
Date: Thu May 8 16:32:54 2014 +0200
Rename folder for Hecke triangle modforms.
}}}
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=6d7348137d982e27990088f352a5194fd967eefa
6d73481]||{{{merge sage-6.6.beta1 in #16976}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16976#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
