#17234: Rich output and the IPython Notebook
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Volker Braun       |    Reviewers:  R. Andrew Ohana
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vbraun/rich_output_and_the_ipython_notebook|  
fcbc5884e9252b75734c125fb436eb26c8d798d6
   Dependencies:  #16996, #16640,    |     Stopgaps:
  #17284                             |
-------------------------------------+-------------------------------------

Comment (by charpent):

 I got 3 failures after "ID 215-02-28-17-11-36-39ff4408", testlong got
 three failures in src/sage/plot/plot3d/base.pyx (see below) , all bound to
 3D graphics. The rest got no failures.

 I got no build failure after integrating the last commit(s), but I did
 '''not''' rebuild from scratch.

 Is that enough for "positive review" ? Do you need a scratch build (long
 since serial : I didn't integrate #17839...) ?

 HTH.

 The three errors :

 {{{
 charpent@asus16-ec:/usr/local/sage-6.6$ sage -t --long --warn-long 24.8
 src/sage/plot/plot3d/base.pyx
 Running doctests with ID 2015-02-28-19-11-29-0b70177c.
 Git branch: t/17234/rich_output_and_the_ipython_notebook
 Doctesting 1 file.
 sage -t --long --warn-long 24.8 src/sage/plot/plot3d/base.pyx
 **********************************************************************
 File "src/sage/plot/plot3d/base.pyx", line 1422, in
 sage.plot.plot3d.base.Graphics3d.save_image
 Failed example:
     G.save_image(gif)
 Exception raised:
     Traceback (most recent call last):
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 492, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 854, in compile_and_execute
         exec(compiled, globs)
       File "<doctest sage.plot.plot3d.base.Graphics3d.save_image[5]>",
 line 1, in <module>
         G.save_image(gif)
       File "sage/plot/plot3d/base.pyx", line 1434, in
 sage.plot.plot3d.base.Graphics3d.save_image
 (build/cythonized/sage/plot/plot3d/base.c:16182)
         Image.open(png).save(filename)
       File "build/bdist.linux-x86_64/egg/PIL/Image.py", line 2006, in open
         raise IOError("cannot identify image file")
     IOError: cannot identify image file
 **********************************************************************
 File "src/sage/plot/plot3d/base.pyx", line 1423, in
 sage.plot.plot3d.base.Graphics3d.save_image
 Failed example:
     assert open(gif).read().startswith('GIF')
 Exception raised:
     Traceback (most recent call last):
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 492, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 854, in compile_and_execute
         exec(compiled, globs)
       File "<doctest sage.plot.plot3d.base.Graphics3d.save_image[6]>",
 line 1, in <module>
         assert open(gif).read().startswith('GIF')
     AssertionError
 **********************************************************************
 File "src/sage/plot/plot3d/base.pyx", line 1474, in
 sage.plot.plot3d.base.Graphics3d.save
 Failed example:
     cube().save(tmp_filename(ext='.gif'))
 Exception raised:
     Traceback (most recent call last):
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 492, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/usr/local/sage-6.6/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 854, in compile_and_execute
         exec(compiled, globs)
       File "<doctest sage.plot.plot3d.base.Graphics3d.save[5]>", line 1,
 in <module>
         cube().save(tmp_filename(ext='.gif'))
       File "sage/plot/plot3d/base.pyx", line 1480, in
 sage.plot.plot3d.base.Graphics3d.save
 (build/cythonized/sage/plot/plot3d/base.c:16543)
         self.save_image(filename)
       File "sage/plot/plot3d/base.pyx", line 1434, in
 sage.plot.plot3d.base.Graphics3d.save_image
 (build/cythonized/sage/plot/plot3d/base.c:16182)
         Image.open(png).save(filename)
       File "build/bdist.linux-x86_64/egg/PIL/Image.py", line 2006, in open
         raise IOError("cannot identify image file")
     IOError: cannot identify image file
 **********************************************************************
 2 items had failures:
    1 of   7 in sage.plot.plot3d.base.Graphics3d.save
    2 of   8 in sage.plot.plot3d.base.Graphics3d.save_image
     [297 tests, 3 failures, 44.46 s]
 ----------------------------------------------------------------------
 sage -t --long --warn-long 24.8 src/sage/plot/plot3d/base.pyx  # 3
 doctests failed
 ----------------------------------------------------------------------
 Total time for all tests: 44.6 seconds
     cpu time: 1.3 seconds
     cumulative wall time: 44.5 seconds
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/17234#comment:58>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to