#6071: [with new patch, needs review] Weight 1 Eisenstein series
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: modular forms | Keywords: eisenstein series
Reviewer: | Author:
Merged: |
---------------------------+------------------------------------------------
Comment(by was):
REFEREE REPORT:
* This comment must be changed, and I've changed it in the attached
referee patch:
{{{
File: /scratch/wstein/build/sage-4.1/local/lib/python2.6/site-
packages/sage/modular/modform/ambient.py
Definition: M.module(self)
Docstring:
Return the underlying free module corresponding to this space
of
modular forms. This is a free module (viewed as a tuple space)
of
the same dimension as this space over the same base ring.
}}}
This is because of the following example:
{{{
sage: M = ModularForms(Gamma1(23), 1,prec=20); M
Modular Forms space of dimension (unknown) for Congruence Subgroup
Gamma1(23) of weight 1 over Rational Field
sage: M.module()
Vector space of dimension 11 over Rational Field
}}}
so it is now no longer the case that {{{M.module().dimension() ==
M.dimension()}}} as is stated in the docstring.
The change should just be to state that "If the dimension of M can be
computed, then [same as before]. Otherwise, the dimension of M.module()
may be smaller. E.g., in the case of weight 1 forms..." Then include an
example in the docstring that illustrates this.
This ticket should be changed to "[with patch; positive review]" as soon
as somebody else signs off on the referee patch I've attached.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6071#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
