#5982: [with patch, needs review] Can't construct fraction field
---------------------+------------------------------------------------------
 Reporter:  jmbr     |       Owner:  tbd           
     Type:  defect   |      Status:  new           
 Priority:  major    |   Milestone:  sage-4.1.1    
Component:  algebra  |    Keywords:                
 Reviewer:           |      Author:  Nick Alexander
   Merged:           |  
---------------------+------------------------------------------------------

Comment(by was):

 Positive review modulo fixing this one trivial change to a doctest:
 {{{
 wst...@sage:~/build/sage-4.1$ ./sage -t
 devel/sage/sage/rings/quotient_ring.py
 sage -t  "devel/sage/sage/rings/quotient_ring.py"
 **********************************************************************
 File
 "/scratch/wstein/build/sage-4.1/devel/sage/sage/rings/quotient_ring.py",
 line 442:
     sage: Q.is_integral_domain()
 Expected:
     Traceback (most recent call last):
     ...
     NotImplementedError
 Got:
     Traceback (most recent call last):
       File "/scratch/wstein/build/sage-4.1/local/bin/ncadoctest.py", line
 1231, in run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/scratch/wstein/build/sage-4.1/local/bin/sagedoctest.py", line
 38, in run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compileflags)
       File "/scratch/wstein/build/sage-4.1/local/bin/ncadoctest.py", line
 1172, in run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_13[7]>", line 1, in <module>
         Q.is_integral_domain()###line 442:
     sage: Q.is_integral_domain()
       File "/scratch/wstein/build/sage-4.1/local/lib/python/site-
 packages/sage/rings/quotient_ring.py", line 447, in is_integral_domain
         return self.defining_ideal().is_prime()
       File "/scratch/wstein/build/sage-4.1/local/lib/python/site-
 packages/sage/rings/polynomial/multi_polynomial_ideal.py", line 854, in
 is_prime
         CPD = self.complete_primary_decomposition(**kwds)
       File "/scratch/wstein/build/sage-4.1/local/lib/python/site-
 packages/sage/rings/polynomial/multi_polynomial_ideal.py", line 401, in
 __call__
         raise ValueError("Coefficient ring must be a field for function
 '%s'."%(self.f.__name__))
     ValueError: Coefficient ring must be a field for function
 'complete_primary_decomposition'.
 **********************************************************************
 1 items had failures:
    1 of   8 in __main__.example_13
 ***Test Failed*** 1 failures.
 For whitespace errors, see the file
 /scratch/wstein/build/sage-4.1/tmp/.doctest_quotient_ring.py
          [1.8 s]
 exit code: 1024

 ----------------------------------------------------------------------
 The following tests failed:


         sage -t  "devel/sage/sage/rings/quotient_ring.py"
 Total time for all tests: 1.8 seconds
 wst...@sage:~/build/sage-4.1$
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5982#comment:15>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to