#17890: Remove _(rich)cmp_c_impl
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.6
Component: cython | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17890 | a830cc93c6bb07565db709bfe03f8acc62034dbb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* commit: => a830cc93c6bb07565db709bfe03f8acc62034dbb
Old description:
> Instead of
> {{{
> def _cmp_(left, right)
> cdef int _cmp_c_impl(left, right) except -2
> }}}
> we should have
> {{{
> cpdef int _cmp_(left, right) except -2
> }}}
>
> Analogously for `_richcmp_`.
New description:
Instead of
{{{
def _cmp_(left, right)
cdef int _cmp_c_impl(left, right) except -2
}}}
we should have
{{{
cpdef int _cmp_(left, right) except -2
}}}
Analogously for `_richcmp_`.
Attached branch passes all doctests, but is somewhat slower than before.
--
Comment:
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=7083f19ecfc83426442aa98c78d50c520337e82e
7083f19]||{{{Remove use of PY_IS_NUMERIC}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7eb0e93b6c74b1e64d11a7ea1ac7fd1cb4c56aa6
7eb0e93]||{{{Move py_scalar_to_element to coerce.pyx}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8300f591ae2987e01d609e856d38758b28c6bf42
8300f59]||{{{trac #17862 (review): doc typo}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a3ea57f12a7063954d9afac9c3cd3ff9ff93430a
a3ea57f]||{{{Merge tag '6.6.beta2' into HEAD}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a830cc93c6bb07565db709bfe03f8acc62034dbb
a830cc9]||{{{Remove _cmp_c_impl and _richcmp_c_impl}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17890#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
