#17928: opposite of cones and fans
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.6
      Component:  geometry           |   Resolution:
       Keywords:  cone, fan,         |    Merged in:
  negative                           |    Reviewers:  Andrey Novoseltsev
        Authors:  Frédéric Chapoton  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/chapoton/17928   |  bdf048609e0f1ac50905a9f7b512a5b8bab7b753
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by novoselt):

 * status:  needs_review => positive_review
 * reviewer:   => Andrey Novoseltsev


Comment:

 Looks good now.

 For fan refinement: assuming they have the same support, you can map
 `fan1` to `fan2` by the identity map and allow domain subdivision. Then
 the domain `fan3` of the resulting `FanMorphism` will be the minimal
 subdivision. It may be nice to implement a method
 `fan1.common_refinement(fan2)` returning such a fan after constructing an
 opposite morphism as well (this will ensure common support, I am not sure
 how to check it otherwise except for the case of complete fans which
 should be handled separately for efficiency).

--
Ticket URL: <http://trac.sagemath.org/ticket/17928#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to