#16534: Basic Block design methods
-------------------------------------+-------------------------------------
       Reporter:  brett              |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:  Block Design,      |    Reviewers:
  Incidence Structure, Residual,     |  Work issues:
  Derived, Complement, Supplement,   |       Commit:
  Union                              |  2a3ec4b10a60faf396b1aca933a7e0b40cc98b35
        Authors:  Brett Stevens      |     Stopgaps:
Report Upstream:  N/A                |
         Branch:  u/brett/design     |
   Dependencies:  #16553             |
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_work


Comment:

 Hello Brett,

 It seems that your branch still includes traces of a failed merge. Look
 for strings like ">>>>" in the design/ files and you will find them.

 Also, I had to ask you about the two "todo" that you add: we have a
 `.is_resolvable` function and all designs are already checked at
 construction time. You will find the 'actual' code in `designs_pyx.pyx`,
 and the calls appear in the `__init__` functions of each class.

 Nathann

 P.S.: Also, something weird happened as every commit appears twice in your
 branch. You will see that if you click on the 'commits' link that appears
 right next to the name of your branch at the head of the ticket.

--
Ticket URL: <http://trac.sagemath.org/ticket/16534#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to