#13982: rewrite sage.combinat.combinat.unordered_tuples using
itertools.combinations_with_replacement
-------------------------------------+-------------------------------------
       Reporter:  nbruin             |        Owner:  sage-combinat
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.5
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:  Vincent Delecroix,
Report Upstream:  N/A                |  Darij Grinberg
         Branch:                     |  Work issues:
  public/combinat/rewrite_unordered_tuples-13982|       Commit:
   Dependencies:                     |  79cb89296fce3f90b9e59cab797e7c7de57443fc
                                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * reviewer:   => Vincent Delecroix, Darij Grinberg


Comment:

 The merge message is fine with me. I'm happy with your changes except I
 think we should remove the todo because having the Gap version allows us
 to do better testing by comparing the output from the algorithms. However
 if you really want to leave those in there, then you can go ahead and set
 a positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/13982#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to