#17973: Better Sage consistency for naming and calling in linear_code
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/better_sage_consistency_for_naming_and_calling_in_linear_code|  
8813983b5f85ceeb0be6377d0248cc1eb19c1e6a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_work
 * reviewer:   => Nathann Cohen


Comment:

 There are two broken doctests in binary_code.pyx:

 {{{
 (tmp|✔)~/sage/coding$ sage -tp 4 -l binary_code.pyx
 too many failed tests, not using stored timings
 Running doctests with ID 2015-03-17-17-31-39-70361bd3.
 Git branch: tmp
 Doctesting 1 file using 4 threads.
 sage -t --long binary_code.pyx
 **********************************************************************
 File "binary_code.pyx", line 1100, in
 sage.coding.binary_code.BinaryCode.apply_permutation
 Failed example:
     B = BinaryCode(codes.ExtendedBinaryGolayCode().gen_mat())
 Expected nothing
 Got:
     doctest:1: DeprecationWarning: gen_mat is deprecated. Please use
 generator_matrix instead.
     See http://trac.sagemath.org/17973 for details.
 **********************************************************************
 File "binary_code.pyx", line 3858, in
 sage.coding.binary_code.BinaryCodeClassifier.put_in_canonical_form
 Failed example:
     B = BinaryCode(codes.ExtendedBinaryGolayCode().gen_mat())
 Expected nothing
 Got:
     doctest:1: DeprecationWarning: gen_mat is deprecated. Please use
 generator_matrix instead.
     See http://trac.sagemath.org/17973 for details.
 **********************************************************************
 2 items had failures:
    1 of   6 in sage.coding.binary_code.BinaryCode.apply_permutation
    1 of   8 in
 sage.coding.binary_code.BinaryCodeClassifier.put_in_canonical_form
     [351 tests, 2 failures, 6.60 s]
 ----------------------------------------------------------------------
 sage -t --long binary_code.pyx  # 2 doctests failed
 ----------------------------------------------------------------------
 Total time for all tests: 6.7 seconds
     cpu time: 6.3 seconds
     cumulative wall time: 6.6 seconds

 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/17973#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to